[PATCH] Eliminate additional redundant copies of Triple objects. NFC.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Tue Jun 23 09:07:45 PDT 2015


Lgtm
On Jun 23, 2015 11:11 AM, "Daniel Sanders" <daniel.sanders at imgtec.com>
wrote:

> http://reviews.llvm.org/D10654
>
> Files:
>   lib/CodeGen/TargetLoweringBase.cpp
>   lib/CodeGen/WinEHPrepare.cpp
>
> Index: lib/CodeGen/TargetLoweringBase.cpp
> ===================================================================
> --- lib/CodeGen/TargetLoweringBase.cpp
> +++ lib/CodeGen/TargetLoweringBase.cpp
> @@ -778,7 +778,7 @@
>    InsertFencesForAtomic = false;
>    MinimumJumpTableEntries = 4;
>
> -  InitLibcallNames(LibcallRoutineNames, Triple(TM.getTargetTriple()));
> +  InitLibcallNames(LibcallRoutineNames, TM.getTargetTriple());
>    InitCmpLibcallCCs(CmpLibcallCCs);
>    InitLibcallCallingConvs(LibcallCallingConvs);
>  }
> Index: lib/CodeGen/WinEHPrepare.cpp
> ===================================================================
> --- lib/CodeGen/WinEHPrepare.cpp
> +++ lib/CodeGen/WinEHPrepare.cpp
> @@ -76,7 +76,7 @@
>    WinEHPrepare(const TargetMachine *TM = nullptr)
>        : FunctionPass(ID) {
>      if (TM)
> -      TheTriple = Triple(TM->getTargetTriple());
> +      TheTriple = TM->getTargetTriple();
>    }
>
>    bool runOnFunction(Function &Fn) override;
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150623/96be7e8b/attachment.html>


More information about the llvm-commits mailing list