[PATCH] [mips] [IAS] Refactor the emitDirectiveModuleFP() functions.

Toma Tabacu toma.tabacu at imgtec.com
Tue Jun 23 02:41:24 PDT 2015


Hi dsanders,

The same kind of refactoring as in D10641.

However, it looks like we weren't changing the STI.FeatureBits at all before. That doesn't seem right to me.

This might need a test case, but I don't know what to put in it, as I'm not very knowledgeable about fpxx.
I would appreciate some help with this. I was thinking of something like this:
  Set -mfp32 on the command line.
  Use .module fp=xx.
At this point, we should be in fpxx mode, but actually we're still in fp32 mode, because we didn't change the STI.FeatureBits, we just updated the flags information.

http://reviews.llvm.org/D10642

Files:
  lib/Target/Mips/AsmParser/MipsAsmParser.cpp
  lib/Target/Mips/MCTargetDesc/MipsTargetStreamer.cpp
  lib/Target/Mips/MipsTargetStreamer.h

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D10642.28211.patch
Type: text/x-patch
Size: 4416 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150623/df4a3eff/attachment.bin>


More information about the llvm-commits mailing list