[PATCH] [LoopDist/LoopVer] Move LoopVersioning to a new module, NFC

hfinkel at anl.gov hfinkel at anl.gov
Mon Jun 22 18:34:39 PDT 2015


================
Comment at: include/llvm/Transforms/Utils/LoopVersioning.h:10
@@ +9,3 @@
+//
+// This file defines various functions that are used to clone chunks of LLVM
+// code for various purposes.  This varies from copying whole modules into new
----------------
This is a stale comment?

================
Comment at: include/llvm/Transforms/Utils/LoopVersioning.h:44
@@ +43,3 @@
+  /// \brief Performs the CFG manipulation part of versioning the loop including
+  /// the DominatorTree and LoopInfo updates.
+  void versionLoop(Pass *P);
----------------
>From this interface, I find it very unclear how you get out the new versioned loop after the CFG mutation is complete.

================
Comment at: lib/Transforms/Utils/LoopVersioning.cpp:10
@@ +9,3 @@
+//
+// This file implements the CloneFunctionInto interface, which is used as the
+// low-level function cloner.  This is used by the CloneFunction and function
----------------
Stale comment?

http://reviews.llvm.org/D10577

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list