[PATCH] Change .thumb_set to have the same error checks as .set

Pete Cooper peter_cooper at apple.com
Mon Jun 22 12:41:38 PDT 2015

> On Jun 22, 2015, at 10:31 AM, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
>> Oh wait, i was wrong.
>> So AsmParser.cpp doesn’t have a header file.  Its a subclass of MCAsmParser.
>> ARMAsmParser itself is a parser extension, but (obviously given there’s no
>> header), there’s no way to get from a parser extension to AsmParser.
>> Everything is connected once you’re down at the MC level, but I didn’t want
>> to expose this functionality in MCAsmParser as it doesn’t fit in with the
>> other methods there.
> I guess I would have a small preference for making
> parseAssignmentExpression a method of MCAsmParser, but the current
> patch LGTM.
Thanks, r240318.

I’ve left it as a utility for now which i hope is ok.  If you later have a stronger preference for moving it to MCAsmParser then let me know and i’ll be happy to move it.

> Cheers,
> Rafael

More information about the llvm-commits mailing list