[llvm] r240317 - Remove "const" from the MachineFunction reference in VLIWPacketizerList

David Blaikie dblaikie at gmail.com
Mon Jun 22 12:41:24 PDT 2015


On Mon, Jun 22, 2015 at 12:14 PM, Krzysztof Parzyszek <
kparzysz at codeaurora.org> wrote:

> Because the subclasses of VLIWPacketizerList can modify the machine
> function.  With this change they can use the MF member from the parent
> class.
>

Might've been helpful to include all/some such changes in the patch to
demonstrate the motivation for the change.

- David


>
> -Krzysztof
>
>
> On 6/22/2015 2:13 PM, Eric Christopher wrote:
>
>> ... why?
>>
>> -eric
>>
>> On Mon, Jun 22, 2015 at 12:06 PM Krzysztof Parzyszek
>> <kparzysz at codeaurora.org <mailto:kparzysz at codeaurora.org>> wrote:
>>
>>     Author: kparzysz
>>     Date: Mon Jun 22 13:59:44 2015
>>     New Revision: 240317
>>
>>     URL: http://llvm.org/viewvc/llvm-project?rev=240317&view=rev
>>     Log:
>>     Remove "const" from the MachineFunction reference in
>> VLIWPacketizerList
>>
>>
>>     Modified:
>>          llvm/trunk/include/llvm/CodeGen/DFAPacketizer.h
>>
>>     Modified: llvm/trunk/include/llvm/CodeGen/DFAPacketizer.h
>>     URL:
>>
>> http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/DFAPacketizer.h?rev=240317&r1=240316&r2=240317&view=diff
>>
>> ==============================================================================
>>     --- llvm/trunk/include/llvm/CodeGen/DFAPacketizer.h (original)
>>     +++ llvm/trunk/include/llvm/CodeGen/DFAPacketizer.h Mon Jun 22
>>     13:59:44 2015
>>     @@ -91,7 +91,7 @@ public:
>>       // API call is made to prune the dependence.
>>       class VLIWPacketizerList {
>>       protected:
>>     -  const MachineFunction &MF;
>>     +  MachineFunction &MF;
>>         const TargetInstrInfo *TII;
>>
>>         // The VLIW Scheduler.
>>
>>
>>     _______________________________________________
>>     llvm-commits mailing list
>>     llvm-commits at cs.uiuc.edu <mailto:llvm-commits at cs.uiuc.edu>
>>     http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>>
>
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted
> by The Linux Foundation
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150622/57cd0c68/attachment.html>


More information about the llvm-commits mailing list