[PATCH] [x86] generalize reassociation optimization in machine combiner to 2 instructions

Gerolf Hoflehner ghoflehner at apple.com
Mon Jun 22 11:48:23 PDT 2015


LGTM, but for compile time please add a FIXME before commit. What more evidence does it need? "On Mehdi's (hopefully degenerate for x86) test case from the r236031 post-commit thread, the compile-time increases from ~0.2 sec to 5.0 sec". However, in the current form the patch should have negligible ct impact in general.


http://reviews.llvm.org/D10460

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list