Patch for http://reviews.llvm.org/D10518
rafael.espindola at gmail.com
Mon Jun 22 11:11:07 PDT 2015
Committed as r240305.
On 22 June 2015 at 14:00, Karl Schimpf <kschimpf at google.com> wrote:
> Your patch looks good. (LGTM). I don't yet have committer privileges, but I
> will try and find someone here to commit it. I will then rebase the CL and
> resend it.
> Karl Schimpf
> On Fri, Jun 19, 2015 at 7:52 AM, Rafael Espíndola
> <rafael.espindola at gmail.com> wrote:
>> invalid-data-after-module.bc is not used.
>> The patch has not been git-clang-formated.
>> It looks like there is an independent part of the patch with is just
>> about removing IsStreamed. I have extracted it to the attached patch.
>> It has a small but noticeable impact on performance. I timed running
>> "opt -disable-output -disable-verify" on a ltoed clang. It goes from
>> 14.752845231 seconds time elapsed
>> ( +- 0.16% )
>> 15.012463721 seconds time elapsed
>> ( +- 0.11% )
>> It is small enough that I think it is worth the dropping of code path
>> differences between the two cases.
>> Do you agree with the attached patch? If so, please commit it first
>> and rebase the rest of your patch.
More information about the llvm-commits