[PATCH] [Object] Search for architecures by name in MachOUniversalBinary::getObjectForArch()

[Frederic Riss]

Hi samsonov, bogner,

The reason we need to search by name rather than by Triple::ArchType
is to handle x86_64h correclty. There is no different ArchType
for the x86_64h architecture (it identifies itself as x86_64), and
this is by design. The only way to get to the x86_64h slice of an
universal binary is to serch by name.

This issue led to hard to debug and transient symbolication failures
in Asan tests (it mostly works, because the files are very similar).

This also affects the Profiling infrastucture as it is the other user
of that API.

http://reviews.llvm.org/D10604

Files:
  include/llvm/Object/MachOUniversal.h
  include/llvm/ProfileData/CoverageMapping.h
  include/llvm/ProfileData/CoverageMappingReader.h
  lib/Object/MachOUniversal.cpp
  lib/ProfileData/CoverageMapping.cpp
  lib/ProfileData/CoverageMappingReader.cpp
  test/tools/llvm-symbolizer/Inputs/fat.x86_64h.c
  test/tools/llvm-symbolizer/Inputs/fat.x86_64h.o
  test/tools/llvm-symbolizer/fat.test
  tools/llvm-cov/CodeCoverage.cpp
  tools/llvm-symbolizer/LLVMSymbolize.cpp

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D10604.28120.patch
Type: text/x-patch
Size: 7452 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150622/2f39a9f8/attachment.bin>