[PATCH] [mips] Add support for branch-likely pseudo-instructions

[Daniel Sanders]

> > Please, take a look at AsmToken::Identifier case, since I am not sure this is the right way to parse a label.

>  You shouldn't need any of the code you added for this. We can already parse labels so specifying 'brtarget' should be sufficient. I'll take a quick look.


Hmm... I see the problem. We use a custom parser function (parseJumpTarget()) for jump targets for various reasons. However, it never calls parseJumpTarget() for these branch likely instructions on 32r6/64r6 because the the AvailableFeatures leave no possibility of a valid match. Then, because it didn't call parseJumpTarget() it isn't able to parse the remainder of the instruction and (correctly) rejects the instruction but for the wrong reason.

Fixing this properly is going to be a bit big for this patch. We either need to eliminate custom parser functions as far as possible in favour of a generic parser along the lines of your change, or change the handling of custom parsers such that the parsing happens regardless of the prospects for a successful match. For this patch, I'd suggest omitting the fix for the wrong-error issue.


http://reviews.llvm.org/D10537

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/