[PATCH] Change .thumb_set to have the same error checks as .set

Pete Cooper peter_cooper at apple.com
Sun Jun 21 10:45:12 PDT 2015


> On Jun 21, 2015, at 5:50 AM, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
> 
> isSymbolUsedInExpression can still be a local static, no?
> 
Ha!  I missed that.  The need to refactor it must have been left over from when I tried to share more code with ARMAsmParser.

I like having it in the MCAsmParserUtils namespace, but can just make it a local static as you said.

Cheers,
Pete
> On Jun 19, 2015 7:50 PM, "Pete Cooper" <peter_cooper at apple.com <mailto:peter_cooper at apple.com>> wrote:
> Hi all
> 
> This is a patch to change .thumb_set to match the same error behavior as .set.
> 
> I’ve factored out the body of AsmParser::parseAssignment to try share the code with the ARMAsmParser.  This required a new header as I couldn’t see a header which made sense.
> 
> Comments welcome.
> 
> Cheers,
> Pete
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150621/52919580/attachment.html>


More information about the llvm-commits mailing list