[llvm] r239943 - AMDGPU: Change unreachable into reported error
dblaikie at gmail.com
Thu Jun 18 10:21:29 PDT 2015
On Wed, Jun 17, 2015 at 6:51 PM, Matt Arsenault <arsenm2 at gmail.com> wrote:
> On Jun 17, 2015, at 6:35 PM, Rafael Espíndola <rafael.espindola at gmail.com>
> Is it testable?
> Not really. The testcase would be pretty big, and it shouldn’t really ever
> happen unless there’s a bug somewhere.
Eh - if it's always a bug (& thus untestable), I'd be inclined not to
support it, even as an error path. That's what assertion failures, etc, are
for. (opinions may differ, though)
> Getting this wrong isn’t going to break the compiler somewhere, so I don’t
> think it should crash and only report that the resulting program probably
> won’t work correctly.
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits