[PATCH] [mips] [IAS] Add support for LAReg with identical source and destination register operands.

Daniel Sanders daniel.sanders at imgtec.com
Thu Jun 18 04:15:02 PDT 2015


> Daniel, is shortening IntermediateDstReg to TmpReg OK with you ?

>  You pointed that out in private, but since I ended up making the change, your position should be included in the public review.

I didn't mind either way. When we spoke, I was making a general comment that descriptive names are generally good but short, non-descriptive names aren't always bad. The obvious example is 'i', and 'j' for loop counters. Personally, I use TmpReg for trivial scratch registers and use more descriptive names when there are several of them (otherwise it starts to get confusing).



More information about the llvm-commits mailing list