[PATCH] CMake: Stop using LLVM's custom parse_arguments. NFC

Filipe Cabecinhas filcab+llvm.phabricator at gmail.com
Wed Jun 17 22:32:40 PDT 2015


Hi pcc, beanz, chapuni,

Use CMake's cmake_parse_arguments() instead.
It's called in a slightly different way, but supports all our use cases.
It's in CMake 2.8.8, which is our minimum supported version.

CMake 3.0 doc (roughly the same. No direct link to 2.8.8 doc):
http://www.cmake.org/cmake/help/v3.0/module/CMakeParseArguments.html?highlight=cmake_parse_arguments

Finally, delete LLVM's parse_arguments() definition.

This is dependent on http://reviews.llvm.org/D10529

http://reviews.llvm.org/D10531

Files:
  cmake/modules/AddLLVM.cmake
  cmake/modules/LLVMParseArguments.cmake

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D10531.27917.patch
Type: text/x-patch
Size: 5897 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150618/ad01900d/attachment.bin>


More information about the llvm-commits mailing list