[PATCH] Refactor bitcode reader to simplify control logic.

Karl Schimpf kschimpf at google.com
Wed Jun 17 13:21:37 PDT 2015


Hi dschuff, jvoung, rafael, filcab,

Modifies the bitcode reader to use the same logic for both memory
buffers and data streams (other than initialization).  The incremental
parser is now factored into startParse, continueParse, and
finishParse. All parses begin with startParse. It then makes zero or
more calls to continueParse (via incremental parsing). Finally, when
materializing, finishParse to finish parsing.

Note that this CL replaces http://reviews.llvm.org/D8786.

http://reviews.llvm.org/D10518

Files:
  include/llvm/Bitcode/BitstreamReader.h
  lib/Bitcode/Reader/BitcodeReader.cpp
  test/Bitcode/Inputs/invalid-abbrev.bc
  test/Bitcode/Inputs/invalid-data-after-module.bc
  test/Bitcode/Inputs/invalid-fwdref-type-mismatch-2.bc
  test/Bitcode/Inputs/invalid-load-ptr-type.bc

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D10518.27866.patch
Type: text/x-patch
Size: 18109 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150617/f8e81253/attachment.bin>


More information about the llvm-commits mailing list