[PATCH] Fix bug 23851: Preserve metadata for the unswitched branch in loop-unswitch

Philip Reames listmail at philipreames.com
Wed Jun 17 13:13:28 PDT 2015

Can you upload a full context diff please?  It's hard to assess what you're changing with the current limited context.

The general direction seems workable.

A couple of questions:

1. Are we sure the direction of the branches are the same?  If not, we may need to invert the profile metadata.
2. Should we passing in the original terminator?  Or just information about the metadata?  Once I have context, I may have suggestions in this area.
3. You should white list the metadata.  Not all metadata will neccessarily apply.



More information about the llvm-commits mailing list