[PATCH] [Zorg] Adding test-suite to CMake ClangBuilder

Renato Golin renato.golin at linaro.org
Wed Jun 17 12:02:07 PDT 2015

Ok, I'll leave it as it is and check with Rick what he prefers for the Windows part. We can refactor that out later. Thanks!

Comment at: zorg/buildbot/builders/ClangBuilder.py:686-688
@@ +685,5 @@
+        # Get generated python, lnt
+        python=WithProperties('%(workdir)s/test/sandbox/bin/python')
+        lnt=WithProperties('%(workdir)s/test/sandbox/bin/lnt')
+        lnt_setup=WithProperties('%(workdir)s/test/lnt/setup.py')
rnk wrote:
> These assignments and others are still not using spaces. I think it bothers me because when you do it like this I assume it's part of a sequence of kwargs and I go looking for a function call to match it up with.
Now I get what you mean by this "not being kwargs"... :)

I'll change those assignments and check for others in a subsequent commit, to make sure I'm not adding a lot of cosmetic unrelated changes.



More information about the llvm-commits mailing list