[patch] Rename and improve emitSectionOffset

Rafael EspĂ­ndola rafael.espindola at gmail.com
Tue Jun 16 12:54:25 PDT 2015

Different object formats represents references from dwarf in different ways.

ELF uses a relocation to the referenced point (except for .dwo) and
COFF/MachO use the offset of the referenced point inside its section.

The attached patch renames emitSectionOffset because

* It doesn't produce an offset on ELF.
* It changes behavior depending on how DWARF is represented, so adding
dwarf to its name is probably a good thing.

The patch also adds an option to force the use of offsets.That avoids
funny looking code like

  if (!UseOffsets)

It was correct, but read as if the ! was inverted.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: t.patch
Type: text/x-patch
Size: 6282 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150616/4ebc2fc3/attachment.bin>

More information about the llvm-commits mailing list