[PATCH] Move the personality function from LandingPadInst to Function

Reid Kleckner rnk at google.com
Mon Jun 15 15:48:14 PDT 2015

I'm happy with this, but we should find another reviewer or two. I'd try Anton for EH stuff and John and Rafael for IR changes.

Comment at: lib/Bitcode/Reader/BitcodeReader.cpp:4063
@@ +4062,3 @@
+        F->setPersonalityFn(cast<Constant>(PersFn));
+      }
What should we do with bitcode that has multiple landing pads with mismatched personalities? Obviously, it's invalid IR, but now we might not detect that anymore, right? Seems like if the parent function has a personality and it doesn't match the one we're adding, we should error.



More information about the llvm-commits mailing list