[PATCH] propagate IR-level fast-math-flags to DAG nodes, disabled by default

Nick Lewycky nlewycky at google.com
Mon Jun 15 15:11:47 PDT 2015

Are you sure you don't need to re-enable any tests with this commit? I'm concerned that there's no test change.

Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:410-412
@@ +409,5 @@
+  unsigned RawFlags = Flags->getRawFlags();
+  // If no flags are set, do not alter the ID. This saves time and allows
+  // a gradual increase in API usage of the optional optimization flags.
+  if (RawFlags != 0)
+    ID.AddInteger(RawFlags);
Are you saying that the FoldingSetNodeID is computed elsewhere too, without using this function? And that we don't want to call AddInteger one more time because we don't want to make it different from that other place of computation?



More information about the llvm-commits mailing list