[PATCH] [Scalarizer] Fix potential for stale data in Scattered across invocations
wala at google.com
Mon Jun 15 13:53:00 PDT 2015
I apologize, I did not mean to break any rules.
On Fri, Jun 12, 2015 at 5:50 PM, Chandler Carruth <chandlerc at google.com>
> Matt, there are a bunch of problems here.
> First, Steve Hines accepted this revision in Phabricator, but didn't
> actually send any LGTM or other comment to the mailing list, so it didn't
> look like *any* review happened.
> Second, Steve, I'm not sure how familiar with this code you are as I've
> never seen you really contribute to it, so it might be better to let others
> review the patch.
> Third, making the point that sufficient review had not happened, this is a
> bugfix patch which does not contain a test case. I feel confident that a
> dangling pointer style bug could be exercised with a good test case and
> ASan. We have ASan bots, so having the test case in the tree is really
> Matt, please update the review thread when you have added such a test case.
I've opened a new review with a test case attached.
Here's the link to the new review: http://reviews.llvm.org/D10459
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits