[PATCH] [ARM] Keep track of previous changes to the bit pattern stored HW_FP

Renato Golin renato.golin at linaro.org
Mon Jun 15 03:27:39 PDT 2015

In http://reviews.llvm.org/D10395#186872, @rs wrote:

> TargetInfo::CreateTargetInfo takes the features from the command line and puts them into a StringMap and pulls them out again which can jumble the order of the features. So if I did write a test there's no guarantee that handleTargetFeatures will see them in the same order that I specified them on the command line. If you have any suggestions on how I can write a test for this then please let me know.

You can use CHECK-DAG, which will match all strings in a list in any order. Please, do write tests for this, it's quite easy to get that wrong.




More information about the llvm-commits mailing list