[PATCH] [ASan] Test churn for setting ASAN_OPTIONS=symbolize_vs_style=false

Alexey Samsonov vonosmas at gmail.com
Sat Jun 13 10:22:23 PDT 2015


LGTM, thanks! Single comment below.


================
Comment at: test/asan/TestCases/stack-use-after-return.cc:15
@@ -14,3 +14,3 @@
 //
-// RUN: env ASAN_OPTIONS=$ASAN_OPTIONS:max_uar_stack_size_log=20:verbosity=1 not %run %t 2>&1 | FileCheck --check-prefix=CHECK-20 %s
-// RUN: env ASAN_OPTIONS=$ASAN_OPTIONS:min_uar_stack_size_log=24:max_uar_stack_size_log=24:verbosity=1 not %run %t 2>&1 | FileCheck --check-prefix=CHECK-24 %s
+// RUN: env ASAN_OPTIONS=$ASAN_OPTIONS:$ASAN_OPTIONS:max_uar_stack_size_log=20:verbosity=1 not %run %t 2>&1 | FileCheck --check-prefix=CHECK-20 %s
+// RUN: env ASAN_OPTIONS=$ASAN_OPTIONS:$ASAN_OPTIONS:min_uar_stack_size_log=24:max_uar_stack_size_log=24:verbosity=1 not %run %t 2>&1 | FileCheck --check-prefix=CHECK-24 %s
----------------
Extra `$ASAN_OPTIONS` here.

================
Comment at: test/asan/TestCases/stack-use-after-return.cc:16
@@ -17,1 +15,3 @@
+// RUN: env ASAN_OPTIONS=$ASAN_OPTIONS:$ASAN_OPTIONS:max_uar_stack_size_log=20:verbosity=1 not %run %t 2>&1 | FileCheck --check-prefix=CHECK-20 %s
+// RUN: env ASAN_OPTIONS=$ASAN_OPTIONS:$ASAN_OPTIONS:min_uar_stack_size_log=24:max_uar_stack_size_log=24:verbosity=1 not %run %t 2>&1 | FileCheck --check-prefix=CHECK-24 %s
 
----------------
And here

http://reviews.llvm.org/D10294

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list