[PATCH] Replace string GNU Triples with llvm::Triple in InitMCObjectFileInfo. NFC.

Renato Golin renato.golin at linaro.org
Fri Jun 12 10:36:26 PDT 2015


================
Comment at: lib/Target/TargetLoweringObjectFile.cpp:47
@@ -46,3 +46,3 @@
   DL = TM.getDataLayout();
-  InitMCObjectFileInfo(TM.getTargetTriple(),
-                       TM.getRelocationModel(), TM.getCodeModel(), *Ctx);
+  InitMCObjectFileInfo(Triple(TM.getTargetTriple()), TM.getRelocationModel(),
+                       TM.getCodeModel(), *Ctx);
----------------
dsanders wrote:
> dsanders wrote:
> > rengolin wrote:
> > > Didn't getTargetTriple return a Triple after your changes? Or is this before that?
> > You're correct, the constructor is unnecessary. I've fixed it in D10382
> Sorry, I'm mixing up 'Depends on' and 'Dependencies' in phabricator. The next patch (D10381) makes getTargetTriple() return a Triple.
Yeah, it's a bit confusing, but as long as it's right in the end, it's ok.

Maybe not squashing all of it for commit, but I normally squash (or diff master) just to see if the overall changes make sense. If they do, and the split makes sense, I'm ok with it.

http://reviews.llvm.org/D10366

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list