[PATCH] [mips] [IAS] Refactor symbol-address loading code into a helper function. NFC.

Daniel Sanders daniel.sanders at imgtec.com
Fri Jun 12 08:28:40 PDT 2015


This version LGTM


================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:1956
@@ -1949,4 +1955,3 @@
 
-void MipsAsmParser::expandLoadAddressSym(
-    const MCOperand &DstRegOp, const MCOperand &SymOp, bool Is32BitSym,
-    SMLoc IDLoc, SmallVectorImpl<MCInst> &Instructions) {
+bool MipsAsmParser::loadSymbolAddress(const MCExpr *SymExpr, unsigned DstReg,
+                                      bool Is32BitSym, SMLoc IDLoc,
----------------
Returning a bool looks useless at the moment but I'm aware that there are cases in your follow-on patches that will need it.

http://reviews.llvm.org/D9523

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list