[PATCH] [ELF] Introduce getValue() for ELF Symbols

Michael Spencer bigcheesegs at gmail.com
Thu Jun 11 14:05:33 PDT 2015


On Thu, Jun 11, 2015 at 1:14 PM, Davide Italiano
<davide.italiano at gmail.com> wrote:
> On Thu, Jun 11, 2015 at 12:23 PM, Rafael Ávila de Espíndola
> <rafael.espindola at gmail.com> wrote:
>> Side question, why do we have Elf_Sym_Base and Elf_Sym_Impl?
>>
>>
>
> The first time I saw it I wondered the same, but I never bothered to ask.
> It think it makes sense just defining an Elf_Sym, and given the linker
> is one of the main consumers of this interface, I don't mind making
> this change. There may be reasons why the code is structured this way,
> but it predates my involvement in LLVM so I'm not aware of them.
> Michael, you introduced this code, can you enlighten us about what's
> the need of having both?
>
> Thanks,
>
> --
> Davide
>
> "A mathematical theory is not to be considered complete until you have
> made it so clear that you can explain it to the first man whom you
> meet on the street." (D. Hilbert)

Elf_Sym_Base abstracts the differences between 32 and 64 bit ELF.
Elf_Sym_Impl defines functions for working with that data.

- Michael Spencer




More information about the llvm-commits mailing list