[PATCH] [AArch64] Match interleaved memory accesses into ldN/stN instructions.

[James Molloy]

Hi Hao,

Thanks for making those changes. With the few typographical comments below corrected, this LGTM.

Thanks!

James


================
Comment at: lib/Target/AArch64/AArch64InterleavedAccess.cpp:1
@@ +1,2 @@
+//=------------- ------- AArch64InterleavedAccess.cpp --------- ------------==//
+//
----------------
Something weird's gone on with this comment line. It's not in the standard form.

================
Comment at: lib/Target/AArch64/AArch64InterleavedAccess.cpp:29
@@ +28,3 @@
+//
+// E.g. Transfer an interleaved store (Factor = 2):
+//        %i.vec = shuffle %v0, %v1, <0, 4, 1, 5, 2, 6, 3, 7>  ; Interleaved vec
----------------
You use the word "transfer" but actually the right word is "transform". Could you please find-and-replace?

================
Comment at: lib/Target/AArch64/AArch64InterleavedAccess.cpp:52
@@ +51,3 @@
+
+#define MIN_FACTOR 2
+#define MAX_FACTOR 4
----------------
We don't use #defines. Suggest you use a static const int MAX_FACTOR = 2; instead.

================
Comment at: lib/Target/AArch64/AArch64InterleavedAccess.cpp:195
@@ +194,3 @@
+
+/// \brief Get a mask consists of sequential integers starting from \p Start.
+///
----------------
consists -> consisting

================
Comment at: lib/Target/AArch64/AArch64TargetMachine.cpp:72
@@ +71,3 @@
+    "aarch64-interleaved-access-opt",
+    cl::desc("Optimize interleaved memory accesses in AArch64 backend"),
+    cl::init(false), cl::Hidden);
----------------
in -> "in the"

http://reviews.llvm.org/D10335

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/