[PATCH] [Zorg] Adding test-suite to CMake ClangBuilder

Galina gkistanova at gmail.com
Wed Jun 10 16:19:15 PDT 2015


Hello Renato,

It seems you just need to build the bootstrapped clang and use it to run the test-suite, right?
May I suggest subclassing the current ClangCMakeBuildFactory instead of adding parameters and more complicated logic?

You can move the getClangCMakeBuildFactory build steps creation to a separate method (similar to addSVNUpdateSteps), call it with the request for 2 stages, and then add whatever it takes to build and run the test-suite in your ClangCMakeAndTestsuiteBuildFactory(?).

Should be more clear code after all.

What do you think?


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D10244

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list