[PATCH] [LNT] Add cflags string argument to lnt (2)

Chris Matthews chris.matthews at apple.com
Wed Jun 10 12:35:39 PDT 2015


Otherwise looks good. Thanks for adding a test!


================
Comment at: lnt/tests/nt.py:136
@@ +135,3 @@
+        if self.cflag_string:
+            import shlex
+            import pipes
----------------
Lets do these imports at the top.  I assume these are in a standard python 2.7 distro?

================
Comment at: lnt/tests/nt.py:139
@@ +138,3 @@
+            # FIXME: This isn't generally OK on Windows :/
+            safely_quoted_on_linux = map(pipes.quote, shlex.split(self.cflag_string))            
+            target_flags.extend(safely_quoted_on_linux)
----------------
unix.  Don't forget poor little OS X!

http://reviews.llvm.org/D10364

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list