[LNT] r239138 - Fix report submission when there are failed tests.

Kristof Beyls kristof.beyls at arm.com
Wed Jun 10 05:35:37 PDT 2015


> From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Chris Matthews
> Sent: 10 June 2015 00:51
> To: Kristof Beyls
> Cc: llvm-commits at cs.uiuc.edu
> Subject: Re: [LNT] r239138 - Fix report submission when there are failed tests.
>
> Yeah, we would have to get them installed there.  I’m not a big fan of these external pip repos. Nothing but trouble, and I think they add very little value.
>
> I was timing mean and median, on a list of 10 numbers.  Our implementation was ~30us (45 when I added the cast), numpy was ~230us.  I assume the overhead is when converting the list into a numpy array before use. 
>
> Rule #1 of data analysis: always use stats routines made by someone who will lose a lot of money if they are wrong. Last thing you want is to be making conclusions based on output from an algorithm written by a long gone grad student who didn’t care about that corner case that you fell into.  Proof: we didn’t even implement mean correctly for all cases.
>
> This alone make me think even if it is slower we should consider using them.

I fully agree!






More information about the llvm-commits mailing list