[PATCH] [ASan] Test churn for setting ASAN_OPTIONS=symbolize_vs_style=false

Alexey Samsonov vonosmas at gmail.com
Tue Jun 9 17:43:17 PDT 2015


> I can change it to either (I think any of these would be preferable to the

>  current patch):

> 

> - use Reid's idea of making a (yet another) single purpose utility (llvm-env)

> - use expansion (ASAN_OPTIONS=$ASAN_OPTIONS:...) instead of spelling out symbolize_vs_style=true again (I didn't think about this one)


^^
Right, let's use this one. We already use similar construct in another places

  $ grep -rnH "$.SAN_OPTIONS" projects/compiler-rt/test/*

> - change lit's shell, if we're sure that's the one that's being used.

> 

>   Thanks,

> 

>   Filipe



http://reviews.llvm.org/D10294

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list