[PATCH] [GVN] Set proper debug locations for some instructions created by GVN.

[Daniel Berlin]

No, they aren't, and it will in fact, often get the wrong location for this.

But given how GVN works, and the expectation that it has that
phitransaddr will insert instructions for it,
this is pretty much the best you can do (unless you want to do nothing).

This is because PHITransAddr does not have any clue in the world about
what computation it is really going to eventually replace, and GVN
can't tell it, because GVN doesn't know either.

(Basically, GVN is asking phi translate "here's a load, translate all
of it's parts". PHI Translate doesn't just do phi translation, it will
in fact, go off looking to see if something might have the same
operands as the result, etc).


It will be "mostly" right for "depth 1" phi translation, however.


On Tue, Jun 9, 2015 at 5:24 PM, Eric Christopher <echristo at gmail.com> wrote:
> The GVN ones seem reasonable since the instructions they're replacing are deleted, are the ones in PHITransAddr the same?
>
> -eric
>
>
> http://reviews.llvm.org/D10351
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits