[PATCH] LibDriver, llvm-lib: introduce.

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Tue Jun 9 14:31:19 PDT 2015


This is fine from the llvm side.

Rui, is this a convenient interface for lld to use?


================
Comment at: lib/LibDriver/LibDriver.cpp:71
@@ +70,3 @@
+namespace {
+class StrDupSaver : public cl::StringSaver {
+  std::vector<char *> Dups;
----------------
We really should just move the string saver that rui implemented to llvm and make it the one true string saver.
At least add a fixme about that.

http://reviews.llvm.org/D10297

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list