[PATCH] COFF: Handle references from LTO object to lazy symbols correctly.

Peter Collingbourne peter at pcc.me.uk
Mon Jun 8 20:35:24 PDT 2015


================
Comment at: COFF/SymbolTable.cpp:329
@@ +328,3 @@
+  if (reportRemainingUndefines())
+    return make_error_code(LLDError::BrokenFile);
+
----------------
ruiu wrote:
> Can we call reportRemainingUndefines after Symtab.addCombinedLTOObject in the Driver to eliminate this call from here?
My reasoning was that because LTO is generally an expensive operation, we'll want to report undefined symbols as soon as possible, rather than wasting time building the LTO object file.

http://reviews.llvm.org/D10332

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list