[PATCH] [FastISel][X86] Constrain register operand class in foldOperandImpl

[Pete Cooper]

Sorry, Phab is acting up, so will use email.

This was in the original, but as your moving the code anyway, can you invert this to remove indentation, i.e.,

+  if (TargetRegisterInfo::isVirtualRegister(Op)) {
…
}
return Op

to

+  if (!TargetRegisterInfo::isVirtualRegister(Op))
  return Op;

…

Similarly, can you make this a foreach loop:

for (unsigned i = 0; i != NumAddrOps; ++i) {

to

for (MachineOperand MO : MOs) {

Thanks for doing all this!

Cheers,
Pete
> On Jun 8, 2015, at 7:00 PM, Keno Fischer <kfischer at college.harvard.edu> wrote:
> 
> Ok, the other changes have gone in. @pete does this look ok to you?
> 
> 
> REPOSITORY
>  rL LLVM
> 
> http://reviews.llvm.org/D6262
> 
> EMAIL PREFERENCES
>  http://reviews.llvm.org/settings/panel/emailpreferences/
> 
>