[PATCH] [Object/ELF] Provide symbol helpers

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Fri Jun 5 19:46:51 PDT 2015


LGTM with a fix for common symbols.


================
Comment at: include/llvm/Object/ELFTypes.h:185
@@ +184,3 @@
+  }
+  bool isDefined() const {
+    return !isUndefinedSymbol() &&
----------------
Now that I think of it, do we count common as defined? For ELF probably.

With that you can use

!isUndefiredSymbol && !(st_shndx >= SHN_LORESERVE && st_shndx < SHN_ABS);

http://reviews.llvm.org/D10264

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list