[compiler-rt] r238874 - Tests: disable test of /proc filesystem on Darwin.

[Duncan P. N. Exon Smith]

> On 2015-Jun-02, at 14:59, Tim Northover <tnorthover at apple.com> wrote:
> 
> Author: tnorthover
> Date: Tue Jun  2 16:59:04 2015
> New Revision: 238874
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=238874&view=rev
> Log:
> Tests: disable test of /proc filesystem on Darwin.
> 
> We don't have it. I'm not entirely sure "Posix" is a good name for that
> directory, but perhaps we should see how it develops.

I think test/asan/TestCases/'s structure is a good indicator:
--
$ ls -1d test/asan/TestCases/*/
test/asan/TestCases/Android/
test/asan/TestCases/Darwin/
test/asan/TestCases/Helpers/
test/asan/TestCases/Linux/
test/asan/TestCases/Posix/
test/asan/TestCases/Windows/
--

IMO this test should be moved to Linux/ (and duplicated to an Android/
directory?), or moved to a LinuxLike/ directory, or the individual test
file disabled on Darwin.  I think it's dangerous to disable the whole
Posix/ directory on Darwin, since people don't tend to look at the
lit.local.cfg files all that often and it won't be obvious.

Evgeniy, you added this test.  Any thoughts on the right thing here?

> 
> Modified:
>    compiler-rt/trunk/test/sanitizer_common/TestCases/Posix/lit.local.cfg
> 
> Modified: compiler-rt/trunk/test/sanitizer_common/TestCases/Posix/lit.local.cfg
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/sanitizer_common/TestCases/Posix/lit.local.cfg?rev=238874&r1=238873&r2=238874&view=diff
> ==============================================================================
> --- compiler-rt/trunk/test/sanitizer_common/TestCases/Posix/lit.local.cfg (original)
> +++ compiler-rt/trunk/test/sanitizer_common/TestCases/Posix/lit.local.cfg Tue Jun  2 16:59:04 2015
> @@ -5,5 +5,5 @@ def getRoot(config):
> 
> root = getRoot(config)
> 
> -if root.host_os in ['Windows']:
> +if root.host_os in ['Windows', 'Darwin']:
>   config.unsupported = True
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits