[llvm] r239117 - MC: Tidy up formatting and doc comments. NFC.

Jim Grosbach grosbach at apple.com
Fri Jun 5 10:28:06 PDT 2015


Thanks. Your attempt to get me to remove it encountered the fact that I hadn’t gotten that far in my email yet this morning. :)

> On Jun 5, 2015, at 10:27 AM, Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote:
> 
> I guess my lazy attempt to get someone else to remove it failed;
> fixed in r239165 :).
> 
>> On 2015-Jun-05, at 10:23, Eric Christopher <echristo at gmail.com> wrote:
>> 
>> It was a stray, happens on occasion. :)
>> 
>> 
>> On Fri, Jun 5, 2015, 10:16 AM Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote:
>> 
>>> On 2015-Jun-04, at 16:25, Jim Grosbach <grosbach at apple.com> wrote:
>>> 
>>> Author: grosbach
>>> Date: Thu Jun  4 18:25:05 2015
>>> New Revision: 239117
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=239117&view=rev
>>> Log:
>>> MC: Tidy up formatting and doc comments. NFC.
>>> 
>>> Modified:
>>>   llvm/trunk/include/llvm/MC/MCMachObjectWriter.h
>>> 
>>> Modified: llvm/trunk/include/llvm/MC/MCMachObjectWriter.h
>>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/MC/MCMachObjectWriter.h?rev=239117&r1=239116&r2=239117&view=diff
>>> ==============================================================================
>>> --- llvm/trunk/include/llvm/MC/MCMachObjectWriter.h (original)
>>> +++ llvm/trunk/include/llvm/MC/MCMachObjectWriter.h Thu Jun  4 18:25:05 2015
>>> @@ -43,7 +43,7 @@ public:
>>>  /// \name Lifetime Management
>>>  /// @{
>>> 
>>> -  virtual void reset() {};
>>> +  virtual void reset(){};
>> 
>> Any idea what this semi-colon is for?
>> 
>> (Without it, I think clang format prefers a space before the {}...)
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 





More information about the llvm-commits mailing list