[PATCH] [LAA] Fix estimation of number of memchecks

silviu.baranga at arm.com silviu.baranga at arm.com
Fri Jun 5 05:40:27 PDT 2015


Thanks both! I'll commit this on Monday (with the fixed remaining issues).


================
Comment at: lib/Analysis/LoopAccessAnalysis.cpp:1135-1136
@@ -1143,4 +1134,4 @@
   // Check that we found the bounds for the pointer.
-  if (CanDoRT)
+  if (NeedRTCheck && CanDoRT)
     DEBUG(dbgs() << "LAA: We can perform a memory runtime check if needed.\n");
   else if (NeedRTCheck) {
----------------
mzolotukhin wrote:
> The debug message no longer needs "if needed" part.
> 
> And by the way, why do we need this change? To me the original and changed versions seem equivalent except that we won't print any message if `NeedRTCheck==false` and `CanDoRT==true` .
Good point. I'll remove this from the final version.

http://reviews.llvm.org/D10217

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list