[PATCH] [mips] [IAS] Add support for BNE and BEQ with an immediate operand.

Daniel Sanders daniel.sanders at imgtec.com
Thu Jun 4 05:53:13 PDT 2015


================
Comment at: lib/Target/Mips/Mips64InstrInfo.td:631-638
@@ +630,9 @@
+
+let hasDelaySlot = 1 in {
+def BneImm : MipsAsmPseudoInst<(outs GPR64Opnd:$rt),
+                               (ins imm64:$imm64, brtarget:$offset),
+                               "bne\t$rt, $imm64, $offset">;
+def BeqImm : MipsAsmPseudoInst<(outs GPR64Opnd:$rt),
+                               (ins imm64:$imm64, brtarget:$offset),
+                               "beq\t$rt, $imm64, $offset">;
+}
----------------
I'm not sure why you moved this to Mips64InstrInfo.td and changed the GPR32's to GPR64's. You only needed to change uimm5 to imm64.

It will LGTM with this put back in MipsInstrInfo.td and the GPR64's reverted to GPR32's.

http://reviews.llvm.org/D9666

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list