[PATCH] [ASan] Make binary name reader cross-platform.

Alexey Samsonov vonosmas at gmail.com
Wed Jun 3 09:19:21 PDT 2015


LGTM with a couple of comments


REPOSITORY
  rL LLVM

================
Comment at: lib/sanitizer_common/sanitizer_common.cc:353
@@ +352,3 @@
+void CacheBinaryName() {
+  CHECK_EQ(binary_name_cache_str[0], 0);
+  ReadBinaryName(binary_name_cache_str, sizeof(binary_name_cache_str));
----------------
  CHECK_EQ('\0', binary_name_cache_str[0]);

================
Comment at: lib/sanitizer_common/sanitizer_common.h:244
@@ -241,1 +243,3 @@
+const char *GetBinaryBasename();
+void CacheBinaryName();
 void DisableCoreDumperIfNecessary();
----------------
This function must have been declared in some other header. Delete it from there.

http://reviews.llvm.org/D10213

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list