[PATCH] Remove SCEVCache and FindConstantPointers from complete loop unrolling heuristic.

[Michael Zolotukhin]

Thanks, Andy!

I also want to wait for a response from Chandler since he put a lot of efforts into this code.

Michael


================
Comment at: lib/Transforms/Scalar/LoopUnrollPass.cpp:304
@@ +303,3 @@
+
+  /// \brief Try to simplify instruction I using its SCEV expression.
+  ///
----------------
atrick wrote:
> "I am"
There is no typo here, but probably I should've added `\param`:
```
/// \brief Try to simplify instruction \param I using its SCEV expression.
```

================
Comment at: lib/Transforms/Scalar/LoopUnrollPass.cpp:326
@@ +325,3 @@
+          AR->evaluateAtIteration(IterationNumber, SE);
+      // Check if the AddRex expression becomes a constant.
+      if (auto *SC = dyn_cast<SCEVConstant>(ValueAtIteration)) {
----------------
atrick wrote:
> "AddRec"
Thanks for the catch!

http://reviews.llvm.org/D10205

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/