[llvm] r236642 - MC: Skip names of temporary symbols in object streamer

Duncan P. N. Exon Smith dexonsmith at apple.com
Tue Jun 2 17:55:01 PDT 2015


> On 2015-Jun-02, at 16:00, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:
> 
>>> On 2015-May-21, at 12:17, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:
>>> 
>>>> +  if (IsTemporary && AlwaysAddSuffix && !UseNamesOnTempLabels)
>>>> +    return new (*this) MCSymbol("", true);
>>> 
>>> Why do you need the AlwaysAddSuffix?
>> 
>> 
>> IIRC, I tried it without and got some test failures; I assume some
>> symbols make it to the object file with `L` or `l` prefixes and need
>> to be stripped by the linker.  I didn't look too deeply, since this
>> got me the same memory win (there must not be many temp symbols with
>> `!AlwaysAddPrefix`).
> 
> You were in the right path. I clarified a bit which temp symbol
> currently need a name in r238887.

Thanks!



More information about the llvm-commits mailing list