[llvm] r235955 - DebugInfo: Support up to 2^16 arguments in a subprogram

[Aboud, Amjad]

Hi Duncan,
Thanks for taking care of this issue.
However, you missed to fix the limit in the lib/AsmParser/LLParser.cpp.
See attached patch file.

Can you take care of this?

Thanks,
Amjad

-----Original Message-----
From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of David Blaikie
Sent: Tuesday, April 28, 2015 19:24
To: llvm-commits at cs.uiuc.edu
Subject: Re: [llvm] r235955 - DebugInfo: Support up to 2^16 arguments in a subprogram

On Tue, Apr 28, 2015 at 2:32 AM, Joerg Sonnenberger <joerg at britannica.bec.de> wrote:
> On Tue, Apr 28, 2015 at 01:07:34AM -0000, Duncan P. N. Exon Smith wrote:
>> Author: dexonsmith
>> Date: Mon Apr 27 20:07:33 2015
>> New Revision: 235955
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=235955&view=rev
>> Log:
>> DebugInfo: Support up to 2^16 arguments in a subprogram
>>
>> Support up to 2^16 arguments to a function.  If we do hit the limit, 
>> assert out rather than restarting at 0 as we've done historically.
>
> Given that this can be triggered easily by user input, should this 
> really be an assert?

Probably not - ideally it'd fail in the verifier, I'd imagine. But I'm not too fussed personally.

- David

>
> Joerg
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Function-#Args-limit-fix.patch
Type: application/octet-stream
Size: 715 bytes
Desc: Function-#Args-limit-fix.patch
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150602/d660b0d3/attachment.obj>