[PATCH] [mips] [IAS] Restore STI.FeatureBits in .set pop.

Toma Tabacu toma.tabacu at imgtec.com
Mon Jun 1 08:42:21 PDT 2015


================
Comment at: test/MC/Mips/set-push-pop-directives.s:70
@@ +69,2 @@
+# CHECK-NOT: :[[@LINE-1]]:5: error: instruction requires a CPU feature not currently enabled
+    .set pop
----------------
dsanders wrote:
> We ought to add a test like:
>   .set msa
>   .set push
>   .set mips32 # MSA not available in MIPS32
>   addvi.b $w1, $w2, 1 # CHECK: :[[@LINE-1]]:5: error: instruction requires a CPU feature not currently enabled
>   .set pop
>   addvi.b $w1, $w2, 1 # CHECK-NOT: :[[@LINE-1]]:5: error: instruction requires a CPU feature not currently enabled
In GAS (and the IAS) ".set mips32" does not turn off MSA.
So there are no errors in this case, but GAS does emit warnings for inappropriate option combos (including MIPS32 and MSA).

These warnings are not implemented in the IAS at the moment.
They can be added in a separate patch, so I don't think they should block this patch.

http://reviews.llvm.org/D9156

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list