[PATCH] [Object, MachO] Introduce MachOObjectFile::load_commands() range iterator.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Mon Jun 1 07:25:24 PDT 2015


If we can instead avoid walking all the load commands that would be
even better :-)

On 29 May 2015 at 21:34, Alexey Samsonov <vonosmas at gmail.com> wrote:
> Wait a second, this is stupid. We're walking through all load commands in the constructor and fail to create an object if another command can't be parsed. We should just cache all the load commands in a vector, and get rid of all this ErrorOr<> stuff. I'll update the patch shortly, sorry for noise.
>
>
> http://reviews.llvm.org/D10144
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>




More information about the llvm-commits mailing list