[PATCH] Add isConstant argument to MDBuilder::createTBAAStructTagNode

hfinkel at anl.gov hfinkel at anl.gov
Mon Jun 1 06:12:51 PDT 2015


================
Comment at: lib/IR/MDBuilder.cpp:175
@@ -175,1 +174,3 @@
+                      createConstant(ConstantInt::get(Int64, Offset)),
+                      createConstant(ConstantInt::get(Int64, IsConstant))};
   return MDNode::get(Context, Ops);
----------------
Please only add the extra parameter if it is true. Let's not increase the memory footprint of the metadata for the common case.

http://reviews.llvm.org/D10160

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list