[PATCH] [llvm] Let Intrinsics.h depend only on the relevant part of Intrinsics.gen (NFC, part of the fix for bug#11951)

Levon Manukyan leon.manukyan at gmail.com
Fri May 29 12:00:59 PDT 2015


> True, but you can still run tablegen multiple times with separate generators,

I have considered that possibility (and mentioned it at 
http://reviews.llvm.org/D10073), but in my humble opinion enhancing 
tblgen's interface with additional named generators for finer-grained 
control over intrinsics generation wouldn't be the right decision.

On 5/29/2015 8:38 PM, Reid Kleckner wrote:
> In http://reviews.llvm.org/D10073#180808, @leon wrote:
>
>> The current use model of tblgen is to write a single output file
>>   specified through the -o option. The file is opened by the
>>   llvm::TableGenMain() function and reaches the emitting code as
>>   raw_ostream&, which prevents the emitting code from writing additional
>>   output files with their names derived from the name of the primary
>>   output file.
>
> True, but you can still run tablegen multiple times with separate generators, and this naturally leverages our other tablegen optimization which only updates the .inc file if it would've changed. I expect this optimization is worth more than the cost of reparsing the .td files.
>
>
> REPOSITORY
>    rL LLVM
>
> http://reviews.llvm.org/D10073
>
> EMAIL PREFERENCES
>    http://reviews.llvm.org/settings/panel/emailpreferences/
>
>




More information about the llvm-commits mailing list