[PATCH] [sanitizer_common] Added VS-style output for source locations

Filipe Cabecinhas filcab+llvm.phabricator at gmail.com
Thu May 28 19:15:55 PDT 2015


It's possible, but has drawbacks:

* ReportErrorSummary wouldn't pick it up (fixable), it's using "%L %F";
* "%L" wouldn't be straightforward to use if the user wanted to change the
default (the user would have to explicitly pass "%s(%l,%c)" where they want
to have the location (instead of simply "%L");
* We would have a different DEFAULT from trunk in our (internal) port,
which would add to merge work (I don't expect it to change much, of course.
But we'd need to take care of it whenever the default changed, in order to
keep up with trunk). This is not something you need to worry, of course.
I'm just adding for completeness.

Points 1 and 2 would also apply to any sanitizer running on Windows, too
(If someone were to use them with VS, it's much easier to simply double
click the output), if we decide to turn on VS-style location info output by
default on this platform.

Thanks,

  Filipe

On Thu, May 28, 2015 at 5:36 PM, Alexey Samsonov <vonosmas at gmail.com> wrote:

> Why does't passing "%s(%l,%c)" in stack_trace_format work for you?
>
>
> http://reviews.llvm.org/D10113
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150528/227cbe45/attachment.html>


More information about the llvm-commits mailing list