[lld] r238115 - [ELF] Fix lld when no unique sections is used
chisophugis at gmail.com
Thu May 28 15:55:48 PDT 2015
On Wed, May 27, 2015 at 9:19 PM, Rafael Espíndola <
rafael.espindola at gmail.com> wrote:
> > It sort of got lost among the other points, but this was meant to be
> > accompanied by "and if the binary is created with yaml2obj anyway, why
> > just check in the yaml?"
> So, there may be a line between the two groups where yaml is the
> easiest way to create a test. So lets say you are reading the code,
> notice something odd and decide to try create a file that will hit an
> assert. Depending on what that assert is, yaml2obj might be the tool
> for the job (or llvm-mc, or an hex editor depending on the assert).
> But most cases I have seen yaml2obj mentioned are for cases that
> someone chanced upon a file that causes an issue and now is trying to
> figure out a way to recreate it with yaml2obj. Since we will always
> want to do something reasonable with that file, why not check it in?
The same reason we generally reduce all other testcases before checking
them in? I don't see how this is any different.
-- Sean Silva
> This patch was just one such case: the patch was written fixing an
> issue on a file that was trivial to create: compile a file with two
> functions using -ffunction-sections -fno-unique-section-names.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits