[PATCH] Refactoring cl::list_storage from "is a" to "has a" std::vector.

Chandler Carruth chandlerc at gmail.com
Thu May 28 13:23:17 PDT 2015


Yuck. But I agree with you completely. I can't bring myself to say this "looks good" but it looks *right*. Go for it.


================
Comment at: include/llvm/Support/CommandLine.h:1291
@@ -1290,1 +1290,3 @@
+// of this list_storage specialization implements the minimum subset of the
+// std::vector API required for all the current clients.
 //
----------------
Add a FIXME comment to indicate that we want to reduce this over time to a reasonably narrow API?

http://reviews.llvm.org/D10093

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list